This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: generate java files for extended_operations.proto #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data.proto and localized_text.proto
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Aug 26, 2021
chingor13
approved these changes
Aug 26, 2021
Neenu1995
added
automerge
Merge the pull request once unit tests and other checks pass.
and removed
automerge
Merge the pull request once unit tests and other checks pass.
labels
Aug 26, 2021
vam-google
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe update the description, because it also regenerates ErrorReasons
Neenu1995
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 26, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 26, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/java-common-protos/compare/v2.3.2...v2.4.0) (2021-08-26) ### Features * add new FieldBehavior NON_EMPTY_DEFAULT ([#191](https://www.github.com/googleapis/java-common-protos/issues/191)) ([acb2206](https://www.github.com/googleapis/java-common-protos/commit/acb2206e4dbe0b94c4ebbbe6bd924a258469f836)) * Add the `principal` field to the ServiceAccountDelegationInfo proto ([#183](https://www.github.com/googleapis/java-common-protos/issues/183)) ([b558909](https://www.github.com/googleapis/java-common-protos/commit/b558909b0355e5878e4785b76105735e2ca25422)) * generate java files for extended_operations.proto ([#200](https://www.github.com/googleapis/java-common-protos/issues/200)) ([fec9c81](https://www.github.com/googleapis/java-common-protos/commit/fec9c8140c1a03f823d69a787b8c1f59d45879a6)) ### Bug Fixes * Add `shopt -s nullglob` to dependencies script ([#189](https://www.github.com/googleapis/java-common-protos/issues/189)) ([89605e8](https://www.github.com/googleapis/java-common-protos/commit/89605e8edb10bb3ab3aaaa49a4cefba3fa590953)) * Update dependencies.sh to not break on mac ([#186](https://www.github.com/googleapis/java-common-protos/issues/186)) ([ae73232](https://www.github.com/googleapis/java-common-protos/commit/ae7323289c966d7690fcfcf672e19a58797be3df)) ### Documentation * modify some field level comments with new details and examples ([b558909](https://www.github.com/googleapis/java-common-protos/commit/b558909b0355e5878e4785b76105735e2ca25422)) ### Dependencies * update dependency com.google.protobuf:protobuf-bom to v3.17.3 ([#185](https://www.github.com/googleapis/java-common-protos/issues/185)) ([6f1b209](https://www.github.com/googleapis/java-common-protos/commit/6f1b209f32d8ee3ae38e9051f29d464fca507c84)) * update dependency io.grpc:grpc-bom to v1.38.1 ([#187](https://www.github.com/googleapis/java-common-protos/issues/187)) ([1086c1c](https://www.github.com/googleapis/java-common-protos/commit/1086c1cb870e49bc4b68992d293176909bc58a2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: generate java files for error_reason.proto and localized_text.proto
BigqueryAuditMetadata is being explicitly removed because it is introducing a circular dependency with iam.Policy.
common-protos cannot depend on iam because iam depends on common protos.
This issue needs to be resolved before BigqueryAuditMetadata can be added to the java-common-protos