Skip to content

Commit

Permalink
deps: update dependency com.google.googlejavaformat:google-java-forma…
Browse files Browse the repository at this point in the history
…t to v1.13.0 (#404)

* deps: update dependency com.google.googlejavaformat:google-java-format to v1.13.0

* deps: update dependency com.coveo:fmt-maven-plugin to v2.12

Along with the update to google-java-format 1.13.0 java 8 support has been dropped. Remove java 8 from generate.yaml matrix and add note to readme that java 11 is a prerequisite.

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
  • Loading branch information
renovate-bot and BenWhitehead authored Nov 22, 2021
1 parent 129b0e8 commit 1c7ff11
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/generate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ 8, 11 ]
java: [ 11 ]
steps:
- uses: actions/checkout@v2
with:
Expand Down
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ released versioned jar of the conformance tests.
Part of the process of updating the conformance tests involves running a maven build for
this project. Ensure that maven 3.6+ is on your `PATH`.

The code formatter we use `google-java-format` requires Java 11+ in order to run. Please
ensure the version of Java used to run Maven meets this requirement.

#### Performing the update

A bash script is available to perform an update. The script can be ran for any branch, so if you
A bash script is available to perform an update. The script can be run for any branch, if you
need to update for a branch other than `main` update the following snippet with your
branch name.

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
<plugin>
<groupId>com.coveo</groupId>
<artifactId>fmt-maven-plugin</artifactId>
<version>2.9</version>
<version>2.12</version>
<executions>
<execution>
<id>format-main</id>
Expand All @@ -208,7 +208,7 @@
<dependency>
<groupId>com.google.googlejavaformat</groupId>
<artifactId>google-java-format</artifactId>
<version>1.7</version>
<version>1.13.0</version>
</dependency>
</dependencies>
</plugin>
Expand Down

0 comments on commit 1c7ff11

Please sign in to comment.