This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: make title and description of Condition Nullable
According to https://cloud.google.com/iam/docs/conditions-overview#syntax_overview both title and description are optional. Currently, AutoValue treats these fields as non-null which goes against the definition from the API. This change may be considered breaking by some criteria, however this class is annotated @BetaApi.
- Loading branch information
1 parent
e7159c2
commit d749b01
Showing
2 changed files
with
35 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
google-cloud-core/src/test/java/com/google/cloud/ConditionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package com.google.cloud; | ||
|
||
import static com.google.common.truth.Truth.assertThat; | ||
|
||
import org.junit.Test; | ||
|
||
public final class ConditionTest { | ||
|
||
@Test | ||
public void title_nullable() { | ||
Condition condition = Condition.newBuilder() | ||
.setTitle(null) | ||
.setDescription("desc") | ||
.setExpression("expr") | ||
.build(); | ||
|
||
assertThat(condition.getTitle()).isNull(); | ||
} | ||
|
||
@Test | ||
public void description_nullable() { | ||
Condition condition = Condition.newBuilder() | ||
.setTitle("title") | ||
.setDescription(null) | ||
.setExpression("expr") | ||
.build(); | ||
|
||
assertThat(condition.getDescription()).isNull(); | ||
} | ||
} |