Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

fix: make title and description of Condition Nullable #1063

Merged
merged 1 commit into from
Jan 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import com.google.api.core.BetaApi;
import com.google.auto.value.AutoValue;
import javax.annotation.Nullable;

/**
* Class for Identity and Access Management (IAM) policies. IAM policies are used to specify access
Expand All @@ -32,9 +33,11 @@
@AutoValue
public abstract class Condition {
/** Get IAM Policy Binding Condition Title */
@Nullable
public abstract String getTitle();

/** Get IAM Policy Binding Condition Description */
@Nullable
public abstract String getDescription();

/** Get IAM Policy Binding Condition Expression */
Expand All @@ -51,10 +54,10 @@ public static Builder newBuilder() {
@AutoValue.Builder
public abstract static class Builder {
/** Set IAM Policy Binding Condition Title */
public abstract Builder setTitle(String title);
public abstract Builder setTitle(@Nullable String title);

/** Set IAM Policy Binding Condition Description */
public abstract Builder setDescription(String description);
public abstract Builder setDescription(@Nullable String description);

/** Set IAM Policy Binding Condition Expression */
public abstract Builder setExpression(String expression);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
* Copyright 2023 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud;

import static com.google.common.truth.Truth.assertThat;

import org.junit.Test;

public final class ConditionTest {

@Test
public void title_nullable() {
Condition condition =
Condition.newBuilder().setTitle(null).setDescription("desc").setExpression("expr").build();

assertThat(condition.getTitle()).isNull();
}

@Test
public void description_nullable() {
Condition condition =
Condition.newBuilder().setTitle("title").setDescription(null).setExpression("expr").build();

assertThat(condition.getDescription()).isNull();
}
}