Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update CI check to use Java 11. #1867

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: Update CI check to use Java 11. #1867

merged 2 commits into from
Oct 4, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 4, 2024 •
edited
Loading

The CI was unable to run because class files required version 11 of Java.

@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/samples.yaml

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Oct 4, 2024
@tom-andersen tom-andersen changed the title Update to Java 11, since runtime doesn't support 8. fix: Update to Java 11, since runtime doesn't support 8. Oct 4, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Oct 4, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@tom-andersen tom-andersen marked this pull request as ready for review October 4, 2024 18:31
@tom-andersen tom-andersen requested review from a team as code owners October 4, 2024 18:31
@tom-andersen tom-andersen added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2024
@tom-andersen tom-andersen added the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 723c7cc into main Oct 4, 2024
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the tomandersen/fixSamplesCI branch October 4, 2024 19:50
@release-please release-please bot mentioned this pull request Oct 4, 2024
Merged
@tom-andersen tom-andersen changed the title fix: Update to Java 11, since runtime doesn't support 8. fix: Update CI check to use Java 11. Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tom-andersen @ehsannas @yoshi-kokoro @cloud-java-bot