Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up final keyword and javaDoc typo #969

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

songkg7
Copy link
Contributor

@songkg7 songkg7 commented Jan 4, 2023

There are some changes that are not related to the functionality.

  1. final keyword does not seem to be used consistently in test code.
  2. final keyword is not required in the method of final class, so removed it.
  3. Fixed some typos in javaDoc.

@songkg7 songkg7 requested review from a team as code owners January 4, 2023 06:04
@google-cla
Copy link

google-cla bot commented Jan 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/java-logging-logback API. labels Jan 4, 2023
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is failing lint test - please take a look and fix

@losalex losalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 5, 2023 01:04
@songkg7
Copy link
Contributor Author

songkg7 commented Jan 5, 2023

I fixed it 😂

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2023
@losalex losalex merged commit 0d8a666 into googleapis:main Jan 5, 2023
@songkg7 songkg7 deleted the songkg7-patch-1 branch January 5, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants