-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set env vars for tests and make it executable #204
Conversation
5c314ca
to
2c16757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like Java 8 samples is still failing
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
============================================
- Coverage 78.88% 78.37% -0.52%
Complexity 302 302
============================================
Files 21 21
Lines 2719 2719
Branches 150 150
============================================
- Hits 2145 2131 -14
Misses 513 513
- Partials 61 75 +14
Continue to review full report at Codecov.
|
This should fix ERROR: (gcloud.auth.activate-service-account) in tests.
Java 11 samples tests passed but Java 8 kept failing with this error:
I had a hard-to-spot typo in
jave8-samples.cfg
. It should have beenjava8-samples.cfg
.