Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document potentially unexpected blocking behavior of publish() method #370

Merged
merged 2 commits into from
Jan 21, 2021
Merged

docs: Document potentially unexpected blocking behavior of publish() method #370

merged 2 commits into from
Jan 21, 2021

Conversation

dpcollins-google
Copy link
Contributor

No description provided.

@dpcollins-google dpcollins-google requested a review from a team as a code owner September 30, 2020 13:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
anguillanneuf
anguillanneuf suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Your commit message doesn't conform to conventional commits.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage     79.20%   79.20%           
  Complexity      320      320           
=========================================
  Files            21       21           
  Lines          2905     2905           
  Branches        159      159           
=========================================
  Hits           2301     2301           
  Misses          537      537           
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.13% <ø> (ø) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb744c...f655d0f. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Oct 1, 2020
@meredithslota meredithslota changed the title docs: Document potentially unexpected blocking behavior of publish() method. docs: Document potentially unexpected blocking behavior of publish() method Jan 21, 2021
@anguillanneuf anguillanneuf merged commit 18b3a2f into master Jan 21, 2021
@anguillanneuf anguillanneuf deleted the docs-publish-block branch January 21, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpcollins-google @anguillanneuf