test: modify tests to use correct quote escaping #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests used invalid escaping of quotes in PostgreSQL queries. They assumed that a quote in a quoted string could be escaped by prefixing it with a backslash. This is however not allowed in PostgreSQL, and instead the quote must be escaped by including the same quote twice in the string. The Spanner Java client library contained a bug that allowed the backslash-escaped quotes to be accepted. This bug has been fixed in 6.25.7 and these tests therefore need to be modified to be able to update to that version. Fixes the build error in #898
product-auto-label
bot
added
size: s
1 task
alicejli
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@rajatbhatta Do you mind taking a look and approving? Thank you! |
rajatbhatta
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests used invalid escaping of quotes in PostgreSQL queries. They
assumed that a quote in a quoted string could be escaped by prefixing
it with a backslash. This is however not allowed in PostgreSQL, and
instead the quote must be escaped by including the same quote twice in
the string.
The Spanner Java client library contained a bug that allowed the
backslash-escaped quotes to be accepted. This bug has been fixed in
6.25.7 and these tests therefore need to be modified to be able to
update to that version.
Fixes the build error in #898