Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: retry backup operations on failure because of pending operations #1092

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

olavloite
Copy link
Collaborator

Retry backup operations during tests that fail because too many other backup operations are pending at that moment.

Fixes #1019

Retry backup operations during tests that fail because too many other backup
operations are pending at that moment.

Fixes #1019
@olavloite olavloite requested a review from thiagotnunes April 23, 2021 11:16
@olavloite olavloite requested a review from a team as a code owner April 23, 2021 11:16
@olavloite olavloite requested a review from a team April 23, 2021 11:16
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1092 (abb9ee3) into master (71d7fd1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1092      +/-   ##
============================================
- Coverage     85.15%   85.12%   -0.03%     
+ Complexity     2720     2716       -4     
============================================
  Files           155      155              
  Lines         14351    14351              
  Branches       1358     1358              
============================================
- Hits          12221    12217       -4     
- Misses         1562     1566       +4     
  Partials        568      568              
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.03% <0.00%> (-1.58%) 13.00% <0.00%> (-2.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.01% <0.00%> (-0.20%) 74.00% <0.00%> (-1.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d7fd1...abb9ee3. Read the comment docs.

@thiagotnunes thiagotnunes added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 25, 2021
@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@olavloite olavloite merged commit e013df7 into master Apr 26, 2021
@olavloite olavloite deleted the issue-1019 branch April 26, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.example.spanner.EncryptionKeyIT: testEncryptedDatabaseAndBackupAndRestore failed
3 participants