Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make valid connection properties public #3546

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

olavloite
Copy link
Collaborator

Make the list of valid connection properties public, so tools that depend on the Connection API can use this to for example generate documentation for valid properties.

@olavloite olavloite requested a review from a team as a code owner December 13, 2024 12:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 13, 2024
@olavloite olavloite force-pushed the make-connection-properties-public branch from 0746702 to 742cddd Compare December 13, 2024 13:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 13, 2024
Make the list of valid connection properties public, so tools that
depend on the Connection API can use this to for example generate
documentation for valid properties.

Also add valid values to the connection properties that have that
(e.g. enums and booleans).
@olavloite olavloite force-pushed the make-connection-properties-public branch from 742cddd to ef5b0e2 Compare December 13, 2024 14:23
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 13, 2024
@rahul2393 rahul2393 merged commit 109f8fc into main Dec 13, 2024
34 checks passed
@rahul2393 rahul2393 deleted the make-connection-properties-public branch December 13, 2024 20:34
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Dec 26, 2024
Make the list of valid connection properties public, so tools that
depend on the Connection API can use this to for example generate
documentation for valid properties.

Also add valid values to the connection properties that have that
(e.g. enums and booleans).

Co-authored-by: rahul2393 <irahul@google.com>
gagangupt16 pushed a commit to gagangupt16/java-spanner that referenced this pull request Dec 27, 2024
Make the list of valid connection properties public, so tools that
depend on the Connection API can use this to for example generate
documentation for valid properties.

Also add valid values to the connection properties that have that
(e.g. enums and booleans).

Co-authored-by: rahul2393 <irahul@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants