fix: update max_in_use_session at 10 mins interval #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
surbhigarg92
force-pushed
the
max_in_use_session
branch
from
cce4419 to
2eec9a6
Compare
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
max_in_use_session
branch
from
2eec9a6 to
ab9f3c5
Compare
rahul2393
approved these changes
Dec 30, 2024
| @@ -2048,6 +2048,7 @@ boolean isClosed() { | |||
|
|
|||
| // Does various pool maintenance activities. | |||
| void maintainPool() { | |||
| Instant currTime = clock.instant(); | |||
There was a problem hiding this comment.
nit: Do we really have to initialize here? Can we initialize before if statement inside synchronized block so that we will get exact current time. It would be okay to initialize here if we don't have synchronized block.
There was a problem hiding this comment.
I just noticed that go does the same way where they are assigning right before if statement. https://github.com/googleapis/google-cloud-go/blob/main/spanner/session.go#L1775
There was a problem hiding this comment.
this currTime is used at multiple places. Inside synchronized block and outside as well. It will be an overkill if we initialize at multiple times. Inside block and outside. WDYT ?
surbhigarg92
added
the
automerge
gcf-merge-on-green
bot
merged commit cc1753d
into
googleapis:main
31 of 32 checks passed
gcf-merge-on-green
bot
removed
the
automerge
sagnghos
pushed a commit
to sagnghos/java-spanner
that referenced
this pull request
Jan 2, 2025
This PR fixes the max_in_use_session value. Currently this value is only reset at client initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the max_in_use_session value. Currently this value is only reset at client initialization.