Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-storage to v2.30.0 #1313

Closed
wants to merge 3 commits into from

Conversation

mpeddada1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested review from a team as code owners December 5, 2023 21:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage-nio API. labels Dec 5, 2023
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Dec 5, 2023
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Dec 5, 2023

Able to reproduce locally where mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true is getting stuck at:

To learn more about service account credentials, see http://cloud.google.com/docs/authentication/external/set-up-adc-on-cloud
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.628 s -- in com.google.cloud.storage.contrib.nio.NIOTest
[INFO] Running com.google.cloud.storage.contrib.nio.StorageOptionsUtilTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s -- in com.google.cloud.storage.contrib.nio.StorageOptionsUtilTest
[INFO] Running com.google.cloud.storage.contrib.nio.CloudStorageReadFileChannelTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in com.google.cloud.storage.contrib.nio.CloudStorageReadFileChannelTest
[INFO] Running com.google.cloud.storage.contrib.nio.testing.FakeStorageRpcTest
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 9:58:36 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.

On the other hand, running the same command from main results in a successful build:

[INFO] Running com.google.cloud.storage.contrib.nio.CloudStorageReadFileChannelTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in com.google.cloud.storage.contrib.nio.CloudStorageReadFileChannelTest
[INFO] Running com.google.cloud.storage.contrib.nio.testing.FakeStorageRpcTest
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
gen1read1 = abc
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
Dec 05, 2023 10:00:37 PM com.google.api.client.googleapis.services.AbstractGoogleClient <init>
WARNING: Application name is not set. Call Builder#setApplicationName.
gen2read1 = def
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.406 s -- in com.google.cloud.storage.contrib.nio.testing.FakeStorageRpcTest

. . .
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Storage Parent 0.127.8-SNAPSHOT:
[INFO] 
[INFO] Storage Parent ..................................... SUCCESS [  1.499 s]
[INFO] Google Cloud NIO ................................... SUCCESS [ 14.530 s]
[INFO] Google Cloud NIO Retrofit Example .................. SUCCESS [  0.812 s]
[INFO] Google Cloud NIO Examples .......................... SUCCESS [  0.529 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18.195 s
[INFO] Finished at: 2023-12-05T22:00:50Z
[INFO] ------------------------------------------------------------------------

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Dec 5, 2023

Observations from running com.google.cloud.storage.contrib.nio.testing.FakeStorageRpcTest in debugger mode in IntelliJ:
The test appears to be getting stuck at the call to getContent in

String gen1read1 = new String(gen1.getContent(), StandardCharsets.UTF_8);

The method Blob#getContent then invokes StorageImpl#readAllBytes which is where the application is getting stuck for a long time.

@mpeddada1
Copy link
Contributor Author

Closing in favor of #1306

@mpeddada1 mpeddada1 closed this Dec 6, 2023
@mpeddada1 mpeddada1 deleted the update-storage-2.30.0 branch December 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. owlbot:ignore instruct owl-bot to ignore a PR size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants