fix: use projectId from CloudStorageConfig #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
============================================
+ Coverage 72.29% 72.57% +0.27%
Complexity 500 500
============================================
Files 29 29
Lines 1664 1670 +6
Branches 277 276 -1
============================================
+ Hits 1203 1212 +9
+ Misses 336 335 -1
+ Partials 125 123 -2
Continue to review full report at Codecov.
|
BenWhitehead
approved these changes
Feb 11, 2021
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| /** Unit tests for {@link CloudStorageFileSystemProvider} late initialization. */ |
There was a problem hiding this comment.
nit: I don't think this comment is true
There was a problem hiding this comment.
lol.... copy paste disaster over here!
| fileSystem.provider().getProject() == null | ||
| ? null | ||
| : Storage.BlobListOption.userProject(fileSystem.provider().getProject())); | ||
| String userProject = fileSystem.config().userProject(); |
There was a problem hiding this comment.
Am I understanding correctly, the bug was reading projectId from the ServiceOptions instead of from the CloudStorageConfig? If so, can we update the commit comment to explain this fact?
There was a problem hiding this comment.
Good call, that's much clearer.
frankyn
force-pushed
the
fix-user-project-failure
branch
from
f97db4d
to
0f64570
Compare
frankyn
changed the title
frankyn
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #352 ☕️