fix(build): revert maven-shade-plugin 3.3.0 #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: storage
kolea2
suggested changes
May 3, 2022
# This is the 1st commit message: fix(build): revert maven-shade-plugin 3.3.0 Due to a bug in maven shade plugin 3.3.0, compile dependencies got stripped from `google-cloud-nio:shaded`. This bug only affects artifacts where shadedArtifactAttached=true. Related: googleapis/java-bigtable-hbase#3600 Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419
product-auto-label
bot
added
size: s
kolea2
approved these changes
May 3, 2022
BenWhitehead
added a commit
that referenced
this pull request
May 25, 2022
Clirr is broken due to #897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in maven shade plugin 3.3.0, compile dependencies got stripped from
google-cloud-nio:shaded. This bug only affects artifacts where shadedArtifactAttached=true.Related: googleapis/java-bigtable-hbase#3600
Reference: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-419