Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new sample storage_configure_retries #1152

Merged
merged 2 commits into from
Jan 6, 2022
Merged

docs: add new sample storage_configure_retries #1152

merged 2 commits into from
Jan 6, 2022

Conversation

BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Nov 17, 2021 •
edited
Loading

Outstanding items:

  • Libraries bom updated to a version which includes google-cloud-storage >= v2.2.0

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Nov 17, 2021
@BenWhitehead BenWhitehead marked this pull request as ready for review December 13, 2021 21:32
@BenWhitehead BenWhitehead requested a review from a team December 13, 2021 21:33
@BenWhitehead BenWhitehead added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Dec 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
@BenWhitehead BenWhitehead requested a review from a team as a code owner December 13, 2021 21:39
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Dec 13, 2021
@BenWhitehead BenWhitehead added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Dec 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
tritone
tritone approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java
.setMaxAttempts(10)
// to set the backoff multiplier to 3.0
.setRetryDelayMultiplier(3.0)
// to set the max duration of all attempts to 5 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrealistically long for a delete, but fine if this is what other langs have.

@BenWhitehead BenWhitehead requested a review from cbonnie January 4, 2022 21:01
@BenWhitehead BenWhitehead merged commit 8634c4b into googleapis:main Jan 6, 2022
@BenWhitehead BenWhitehead deleted the retry-samples branch January 6, 2022 17:47
cbonnie
cbonnie reviewed Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@cbonnie cbonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few edits, otherwise LGTM.

samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/ConfigureRetries.java Show resolved Hide resolved
@BenWhitehead BenWhitehead mentioned this pull request Jan 6, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbonnie cbonnie cbonnie left review comments

@tritone tritone tritone approved these changes

Assignees

@eaball35 eaball35

Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
Retry Conformance Project
Development

Successfully merging this pull request may close these issues.
4 participants
@BenWhitehead @tritone @cbonnie @eaball35