Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix JSON read handling when socket broken resulting in partial bytes copied #2303

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Add integration test with testbench to force failure during read

Fixes #2301

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 14, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner November 14, 2023 18:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Nov 14, 2023
…ytes copied

Add integration test with testbench to force failure during read

Update retry conformance tests to assert full byte content when read through reader

Fixes #2301
Copy link
Collaborator

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead BenWhitehead merged commit d4bfcf0 into main Nov 14, 2023
20 checks passed
@BenWhitehead BenWhitehead deleted the fix-2301 branch November 14, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP cloud storage downloaded file corruption
2 participants