-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose the methods of Notifications #399
Merged
sydney-munro
merged 18 commits into
googleapis:main
from
athakor:storage-notification-138
Mar 25, 2022
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9df0f93
feat: expose bucket notifications apis
athakor ce09c25
feat: expose bucket notifications apis
athakor 8489ff2
feat: simplified the code and fixed the review changes
athakor 9d0e8c4
feat: fix review changes
athakor cd3776f
feat: addressed review changes
athakor ec7c50c
feat: change javaDoc
athakor 500e025
feat: addressed review changes
athakor 0dbf979
feat: fix review changes
athakor 915dca4
feat: addressed few nits
athakor 2897b6b
feat: fix review changes
athakor 45ae9d9
feat: fix minor changes and change the tests to provide better coverage
athakor 296d5e5
feat: add more checks in test
athakor 9723a54
feat: updated checks
athakor a4bdc42
feat: address the additional comments
athakor 7cbda36
feat: addressed the nits
athakor 50e77a8
feat: update test method name
athakor ea6fc35
Fix StorageImpl
sydney-munro 9d97576
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
google-cloud-storage/src/main/java/com/google/cloud/storage/Notification.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,139 @@ | ||
/* | ||
* Copyright 2020 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.google.cloud.storage; | ||
|
||
import static com.google.common.base.Preconditions.checkNotNull; | ||
|
||
import java.util.Map; | ||
import java.util.Objects; | ||
|
||
/** | ||
* The class representing Pub/Sub notifications for the Storage. See <a | ||
* href="https://cloud.google.com/storage/docs/pubsub-notifications">pubsub-notifications</a> for | ||
* details. | ||
*/ | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
athakor marked this conversation as resolved.
Show resolved
Hide resolved
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public class Notification extends NotificationInfo { | ||
|
||
private final StorageOptions options; | ||
private transient Storage storage; | ||
|
||
/** Builder for {@code Notification}. */ | ||
public static class Builder extends NotificationInfo.Builder { | ||
private final Storage storage; | ||
private final NotificationInfo.BuilderImpl infoBuilder; | ||
|
||
Builder(Notification notification) { | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
this.storage = notification.storage; | ||
this.infoBuilder = new NotificationInfo.BuilderImpl(notification); | ||
} | ||
|
||
@Override | ||
Builder setNotificationId(String notificationId) { | ||
infoBuilder.setNotificationId(notificationId); | ||
return this; | ||
} | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@Override | ||
public Builder setSelfLink(String selfLink) { | ||
infoBuilder.setSelfLink(selfLink); | ||
return this; | ||
} | ||
|
||
@Override | ||
public Builder setTopic(String topic) { | ||
infoBuilder.setTopic(topic); | ||
return this; | ||
} | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@Override | ||
public Builder setPayloadFormat(PayloadFormat payloadFormat) { | ||
infoBuilder.setPayloadFormat(payloadFormat); | ||
return this; | ||
} | ||
|
||
@Override | ||
public Builder setObjectNamePrefix(String objectNamePrefix) { | ||
infoBuilder.setObjectNamePrefix(objectNamePrefix); | ||
return this; | ||
} | ||
|
||
@Override | ||
public Builder setEventTypes(EventType... eventTypes) { | ||
infoBuilder.setEventTypes(eventTypes); | ||
return this; | ||
} | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@Override | ||
public Builder setEtag(String etag) { | ||
infoBuilder.setEtag(etag); | ||
return this; | ||
} | ||
|
||
@Override | ||
public Builder setCustomAttributes(Map<String, String> customAttributes) { | ||
infoBuilder.setCustomAttributes(customAttributes); | ||
return this; | ||
} | ||
|
||
@Override | ||
public Notification build() { | ||
return new Notification(storage, infoBuilder); | ||
} | ||
} | ||
|
||
Notification(Storage storage, NotificationInfo.BuilderImpl infoBuilder) { | ||
athakor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
super(infoBuilder); | ||
this.storage = checkNotNull(storage); | ||
this.options = storage.getOptions(); | ||
} | ||
|
||
/** Returns the notification's {@code Storage} object used to issue requests. */ | ||
public Storage getStorage() { | ||
return storage; | ||
} | ||
|
||
@Override | ||
public Builder toBuilder() { | ||
return new Notification.Builder(this); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object o) { | ||
if (this == o) { | ||
return true; | ||
} | ||
if (o == null || getClass() != o.getClass()) { | ||
return false; | ||
} | ||
if (!super.equals(o)) { | ||
return false; | ||
} | ||
Notification notification = (Notification) o; | ||
return Objects.equals(toPb(), notification.toPb()) | ||
&& Objects.equals(options, notification.options); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(super.hashCode(), options, storage); | ||
} | ||
|
||
static Notification fromPb( | ||
Storage storage, com.google.api.services.storage.model.Notification notificationPb) { | ||
return new Notification( | ||
storage, new NotificationInfo.BuilderImpl(NotificationInfo.fromPb(notificationPb))); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a major version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankyn what do you think about this??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've done it for others and updated the README.md to reflect this quirk in updates of the Interface. We haven't hit customer issues with these interface changes.
We are going to move forward with similar changes.