-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: When passing a sub-array (offset, length) to the Storage#create method the array is needlessly cloned #506
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
============================================
+ Coverage 64.69% 64.71% +0.02%
+ Complexity 629 620 -9
============================================
Files 32 32
Lines 5249 5252 +3
Branches 509 510 +1
============================================
+ Hits 3396 3399 +3
Misses 1694 1694
Partials 159 159
Continue to review full report at Codecov.
|
@googlebot I signed it! |
the array is needlessly cloned leading to unnecessary memory allocations. Signed-off-by: benoit <b.wiart@ubik-ingenierie.com>
d0e86f2
to
25197b3
Compare
Thanks @benbenw, pending CI passing and then it should merge. |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.113.1](https://www.github.com/googleapis/java-storage/compare/v1.113.0...v1.113.1) (2020-09-17) ### Bug Fixes * KMS Bad Key error when using existing Blob context to overwrite object ([#507](https://www.github.com/googleapis/java-storage/issues/507)) ([4d9c490](https://www.github.com/googleapis/java-storage/commit/4d9c49027e4746ee273902694441886c2f43188d)) * When passing a sub-array (offset, length) to the Storage#create method the array is needlessly cloned ([#506](https://www.github.com/googleapis/java-storage/issues/506)) ([9415bb7](https://www.github.com/googleapis/java-storage/commit/9415bb7bdb42d8012ca457a90070b616e6bbec19)), closes [#505](https://www.github.com/googleapis/java-storage/issues/505) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20200814-1.30.10 ([#499](https://www.github.com/googleapis/java-storage/issues/499)) ([af91d7d](https://www.github.com/googleapis/java-storage/commit/af91d7da4117fb22992d6a860af61f72906e0aa1)) ### Documentation * update libraries-bom ([#504](https://www.github.com/googleapis/java-storage/issues/504)) ([0e58c1c](https://www.github.com/googleapis/java-storage/commit/0e58c1cb2b6a890e567b043188613021592f2bc8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
leading to unnecessary memory allocations.
No new tests as it was already covered.
Signed-off-by: benoit b.wiart@ubik-ingenierie.com
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #505 ☕️