Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

chore: mark native image checks as required #936

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Conversation

mpeddada1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested a review from a team as a code owner June 29, 2022 14:41
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 29, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added the api: vision Issues related to the googleapis/java-vision API. label Jun 29, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@alicejli
Copy link

Samples are failing:

[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ReferenceImageManagement.java:[62,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ReferenceImageManagement.java:[90,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductManagement.java:[61,50] error: cannot find symbol
  symbol:   method formatLocationName(String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductManagement.java:[89,50] error: cannot find symbol
  symbol:   method formatLocationName(String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductManagement.java:[124,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductManagement.java:[161,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductManagement.java:[205,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductSearch.java:[80,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductSetManagement.java:[55,50] error: cannot find symbol
  symbol:   method formatLocationName(String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductSetManagement.java:[84,50] error: cannot find symbol
  symbol:   method formatLocationName(String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductSetManagement.java:[118,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductSetManagement.java:[151,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductInProductSetManagement.java:[56,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductInProductSetManagement.java:[84,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductInProductSetManagement.java:[122,29] error: cannot find symbol
  symbol:   method formatProductSetName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ProductInProductSetManagement.java:[126,29] error: cannot find symbol
  symbol:   method formatProductName(String,String,String)
  location: class ProductSearchClient
[ERROR] /tmpfs/src/github/java-vision/samples/snippets/src/main/java/com/example/vision/ImportProductSets.java:[60,50] error: cannot find symbol
  symbol:   method formatLocationName(String,String)
  location: class ProductSearchClient
[INFO] 17 errors

@meltsufin meltsufin merged commit 4e894da into main Jul 21, 2022
@meltsufin meltsufin deleted the require-graal-check branch July 21, 2022 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vision Issues related to the googleapis/java-vision API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants