Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update token endpoints to non-deprecated endpoints #466

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: update token endpoints to non-deprecated endpoints #466

wants to merge 3 commits into from

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #388 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner August 23, 2023 14:41
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 23, 2023
@ddelgrosso1
Copy link
Contributor Author

Both of the endpoints changed in this PR are marked as deprecated / extremely deprecated per documentation. Please feel free to reach out for more information.

I also cleaned up some unused variables in tests that were giving linter warnings.

@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2023
@ddelgrosso1
Copy link
Contributor Author

Marking do not merge until freeze is over.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2023
@ddelgrosso1 ddelgrosso1 mentioned this pull request Aug 23, 2023
Closed
sai-sunder-s
sai-sunder-s reviewed Aug 23, 2023
View reviewed changes
src/index.ts Outdated
const GOOGLE_REVOKE_TOKEN_URL =
'https://accounts.google.com/o/oauth2/revoke?token=';
'https://oauth2.googleapis.com/token/revoke?token=';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you get this revoke url from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation it said that the revoke old url (accounts.google.com) was extremely deprecated, so I browsed through the proto from the yaqs issue and saw revoke was in there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. As long as it works, it should be ok.

ddelgrosso1
ddelgrosso1 commented Oct 20, 2023
View reviewed changes
src/index.ts
const GOOGLE_TOKEN_URL = 'https://www.googleapis.com/oauth2/v4/token';
const GOOGLE_REVOKE_TOKEN_URL =
'https://accounts.google.com/o/oauth2/revoke?token=';
const GOOGLE_TOKEN_URL = 'https://oauth2.googleapis.com/token';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/googleapis/google-api-php-client/blob/7a95ed29e4b6c6859d2d22300c5455a92e2622ad/src/Client.php#L56

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 20, 2023
@ddelgrosso1 ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 20, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2023
ddelgrosso1
ddelgrosso1 commented Oct 24, 2023
View reviewed changes
src/index.ts
const GOOGLE_REVOKE_TOKEN_URL =
'https://accounts.google.com/o/oauth2/revoke?token=';
const GOOGLE_TOKEN_URL = 'https://oauth2.googleapis.com/token';
const GOOGLE_REVOKE_TOKEN_URL = 'https://oauth2.googleapis.com/revoke?token=';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/googleapis/google-auth-library-ruby/blob/2574faf1474711e581cdfde508387630ea3c4b8f/lib/googleauth/user_refresh.rb#L36

@danielbankhead danielbankhead mentioned this pull request Nov 29, 2023
Closed
This was referenced Feb 5, 2024
Merged
Open
@danielbankhead danielbankhead mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s left review comments

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move away from /v4 token endpoint to https://oauth2.googleapis.com/token
3 participants
@ddelgrosso1 @sai-sunder-s @danielbankhead