Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: move to node 14 as minimum version #457

Merged
merged 8 commits into from
Jul 11, 2023
Merged

chore!: move to node 14 as minimum version #457

merged 8 commits into from
Jul 11, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner July 6, 2023 15:05
@generated-files-bot
Copy link

generated-files-bot bot commented Jul 6, 2023 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node12/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 6, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@ddelgrosso1
Copy link
Contributor Author

Need to make sure that #452 goes along with the upgrade / major version bump.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. size: s Pull request size is small. and removed size: s Pull request size is small. size: m Pull request size is medium. labels Jul 6, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@sofisl sofisl self-requested a review July 10, 2023 19:38
sofisl
sofisl requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@sofisl sofisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also remove the Node 12 folders in Kokoro, e.g.: https://github.com/googleapis/node-gtoken/tree/main/.kokoro/continuous/node12

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 10, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2023
@sofisl sofisl closed this Jul 11, 2023
@sofisl sofisl reopened this Jul 11, 2023
@sofisl sofisl closed this Jul 11, 2023
@sofisl sofisl reopened this Jul 11, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2023
@ddelgrosso1 ddelgrosso1 merged commit 429df81 into googleapis:main Jul 11, 2023
@release-please release-please bot mentioned this pull request Jul 11, 2023
Merged
@ddelgrosso1 ddelgrosso1 deleted the node-14 branch July 11, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelgrosso1 @sofisl