This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
feat: adds cleaner utility for orphaned resources #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
- Coverage 98.82% 98.81% -0.01%
==========================================
Files 15 15
Lines 20493 20493
Branches 575 575
==========================================
- Hits 20253 20251 -2
- Misses 232 234 +2
Partials 8 8
Continue to review full report at Codecov.
|
bcoe
suggested changes
Jan 6, 2021
samples/test/clean.js
Outdated
| datasetDeletionOperations.push(deletionOp); | ||
| } | ||
|
|
||
| if (datasetDeletionOperations.length > MAXIMUM_NUMBER_OF_DELETIONS) { |
There was a problem hiding this comment.
The reason you're bumping into an LRO issue, I expect, is that Promise.all will start all the work in parallel, leading to resource contention.
Instead you could just do:
for (const dataset of datasets) {
await datasetDeletionOperations(dataset)
}And I think wouldn't need to cap the amount of cleanup you do.
bcoe
approved these changes
Jan 7, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 12, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.1.0...v1.2.0) (2021-01-09) ### Features * adds cleaner utility for orphaned resources ([#34](https://www.github.com/googleapis/nodejs-ai-platform/issues/34)) ([7c09258](https://www.github.com/googleapis/nodejs-ai-platform/commit/7c09258eb99d9c40ba7bf28b6d84434d6bb8a5b9)) * adds style enumeration ([#37](https://www.github.com/googleapis/nodejs-ai-platform/issues/37)) ([81c1515](https://www.github.com/googleapis/nodejs-ai-platform/commit/81c15150f55c4ef20359c1e48530f2c9bcd0f64b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the clean.js script to clean up old, stale, or orphaned resources greater than 2 days old. It deletes the following types of resources:
Fixes #26