This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: synth.py clean up for multiple version #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 96.45% 96.25% -0.20%
==========================================
Files 11 11
Lines 4057 4057
Branches 234 230 -4
==========================================
- Hits 3913 3905 -8
- Misses 139 147 +8
Partials 5 5
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 4, 2020
| @@ -47,21 +48,25 @@ | |||
|
|
|||
There was a problem hiding this comment.
Do we still need to exclude the src/index.ts? And seems we reformat the synth.py, is this from some tool?
There was a problem hiding this comment.
Good catch. Removed.
xiaozhenliu-gg5
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.