Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: add SearchAllResources and SearchAllIamPolicies rpcs in asset service proto #332

Merged
merged 2 commits into from
May 20, 2020

Conversation

xiaozhenliu-gg5
Copy link
Contributor

@xiaozhenliu-gg5 xiaozhenliu-gg5 commented May 20, 2020

feat: add SearchAllResources and SearchAllIamPolicies rpcs in asset service proto
feat: add ResourceSearchResult and IamPolicySearchResult messages in asset proto
fix: run compile protos script in npm prepare

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #332 into master will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   96.61%   97.10%   +0.48%     
==========================================
  Files          11       11              
  Lines        4165     4867     +702     
  Branches      235      251      +16     
==========================================
+ Hits         4024     4726     +702     
  Misses        136      136              
  Partials        5        5              
Impacted Files Coverage Δ
src/v1/asset_service_client.ts 98.77% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238c11a...55ee45f. Read the comment docs.

@alexander-fenster
Copy link
Contributor

Please make it feat: with the proper description though :)

@xiaozhenliu-gg5 xiaozhenliu-gg5 changed the title fix: run compile protos script for new changes in proto file feat: add SearchAllResources and SearchAllIamPolicies rpcs in asset service proto May 20, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 changed the title feat: add SearchAllResources and SearchAllIamPolicies rpcs in asset service proto feat: add SearchAllResources and SearchAllIamPolicies rpcs in asset service proto May 20, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 merged commit 2f896c4 into master May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants