Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

refactor(samples): convert sample tests from ava to mocha #56

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

nareshqlogic
Copy link
Contributor

Fixes convert all sample tests from ava to mocha #2865 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@JustinBeckwith
Copy link
Contributor

@nareshqlogic I invited you to the googleapis org so your tests run automatically. Can you please check your email and accept those invitations? Thanks!

@nareshqlogic
Copy link
Contributor Author

nareshqlogic commented Nov 20, 2018

Hi @JustinBeckwith,

I didn't get email regarding googleapis org. Can you please resend ?

@JustinBeckwith
Copy link
Contributor

I tried sending it again scratches head what happens if you visit https://github.com/googleapis?

@JustinBeckwith
Copy link
Contributor

(also looks like you need to npm run fix)

@nareshqlogic
Copy link
Contributor Author

If I visit https://github.com/googleapis then I will be able to see googleapis and as well as view invitation link. After clicking on link it moves on two_factor_authentication. Here I am not able to set country code for India. Will it work without two_factor_authentication?

@JustinBeckwith
Copy link
Contributor

Nope, you need to have two factor auth enabled. Can you use the Google Authenticator app for android or iOS?

@nareshqlogic
Copy link
Contributor Author

Hi @JustinBeckwith,
Now I have enabled two factor auth and I fix the lint issue.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2018
@JustinBeckwith JustinBeckwith merged commit d03fb62 into googleapis:master Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants