Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Fix 404 link to product reference docs. #62

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Fix 404 link to product reference docs. #62

merged 2 commits into from
Dec 3, 2018

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 3, 2018

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@crwilcox crwilcox requested a review from jkwlui December 3, 2018 18:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2018
@JustinBeckwith
Copy link
Contributor

Since this is a link to the product docs, should we use this instead?
https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview

@crwilcox
Copy link
Contributor Author

crwilcox commented Dec 3, 2018

I am alright with that instead. This is a subtly different lib to others so was trying to pick something similar.

@JustinBeckwith JustinBeckwith merged commit 33a7cb6 into master Dec 3, 2018
@jmdobry jmdobry deleted the bug-120266122 branch December 5, 2018 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @JustinBeckwith @googlebot