Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate format specific row_count field in Read API #249

Merged
merged 22 commits into from
Apr 11, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 17, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 438434001

Source-Link: googleapis/googleapis@727f08b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2d62ab0d3d650b7aba4ec5e5a96dd8cdbae89fb7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2MmFiMGQzZDY1MGI3YWJhNGVjNWU1YTk2ZGQ4Y2RiYWU4OWZiNyJ9

chore: update v2.14.2 gapic-generator-typescript
Committer: @summer-ji-eng
PiperOrigin-RevId: 434859890

Source-Link: googleapis/googleapis@bc2432d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/930b673103e92523f8cfed38decd7d3afae8ebe7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9

chore: update v2.14.1 gapic-generator-typescript
Committer: @summer-ji-eng
PiperOrigin-RevId: 433031262

Source-Link: googleapis/googleapis@2a55d13

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2fce3893ae9da47763e0872c4a3a87d9ff78771f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZjZTM4OTNhZTlkYTQ3NzYzZTA4NzJjNGEzYTg3ZDlmZjc4NzcxZiJ9

docs: improve documentation for write client
feat: update default timeout/retry information
feat: update parent annotation for BatchCommitWriteStreamsRequest
feat: expose additional StorageError enum values

PiperOrigin-RevId: 431973595

Source-Link: googleapis/googleapis@25d691b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0ca21879ae3136a2d71fa824b49dfaf8a0ae0f2e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGNhMjE4NzlhZTMxMzZhMmQ3MWZhODI0YjQ5ZGZhZjhhMGFlMGYyZSJ9

feat: add trace_id for Read API
PiperOrigin-RevId: 429809867

Source-Link: googleapis/googleapis@6052603

Source-Link: https://github.com/googleapis/googleapis-gen/commit/840dd14c91a0ec66d9bd1a028d01b5fd029ca02e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODQwZGQxNGM5MWEwZWM2NmQ5YmQxYTAyOGQwMWI1ZmQwMjljYTAyZSJ9

docs(samples): include metadata file, add exclusions for samples to handwritten libraries
PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ed74f970fd82914874e6b27b04763cfa66bafe9b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

fix!: remove bigquery.readonly auth scope
PiperOrigin-RevId: 429331987

Source-Link: googleapis/googleapis@4b2bd26

Source-Link: https://github.com/googleapis/googleapis-gen/commit/fa17f03b5ae96316cd02f2997f2fd1196e034e5e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmExN2YwM2I1YWU5NjMxNmNkMDJmMjk5N2YyZmQxMTk2ZTAzNGU1ZSJ9

PiperOrigin-RevId: 429331987

Source-Link: googleapis/googleapis@4b2bd26

Source-Link: googleapis/googleapis-gen@fa17f03
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmExN2YwM2I1YWU5NjMxNmNkMDJmMjk5N2YyZmQxMTk2ZTAzNGU1ZSJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 17, 2022 19:48
@gcf-owl-bot gcf-owl-bot bot requested review from a team and steffnay February 17, 2022 19:48
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 17, 2022
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. label Feb 17, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 17, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 17, 2022
…andwritten libraries

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: remove bigquery.readonly auth scope docs(samples): include metadata file, add exclusions for samples to handwritten libraries Feb 18, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2022
@tmatsuo tmatsuo added the automerge Merge the pull request once unit tests and other checks pass. label Mar 16, 2022
@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 17, 2022

The samples test fails with

Error: 3 INVALID_ARGUMENT: Header 'x-goog-request-params' contains key 'writeStream' that could not be parsed.

@summer-ji-eng Does it ring a bell?

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2022
PiperOrigin-RevId: 438434001

Source-Link: googleapis/googleapis@727f08b

Source-Link: googleapis/googleapis-gen@2d62ab0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmQ2MmFiMGQzZDY1MGI3YWJhNGVjNWU1YTk2ZGQ4Y2RiYWU4OWZiNyJ9
@gcf-owl-bot gcf-owl-bot bot changed the title chore: update v2.14.2 gapic-generator-typescript feat: Deprecate format specific row_count field in Read API Mar 31, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2022
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Apr 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2022
@summer-ji-eng
Copy link
Contributor

summer-ji-eng commented Apr 8, 2022

The samples test fails with

Error: 3 INVALID_ARGUMENT: Header 'x-goog-request-params' contains key 'writeStream' that could not be parsed.

@summer-ji-eng Does it ring a bell?

The error is coming from gRPC service. gax take the option bypass to the service and didn't modify the header. And I tried in different version of gax, it comes the same error.

So I think it is worth to contact the API service team. Maybe @steffnay. Do you have any idea?

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2022
@steffnay steffnay merged commit fb8acf1 into main Apr 11, 2022
@steffnay steffnay deleted the owl-bot-copy branch April 11, 2022 21:13
@steffnay steffnay restored the owl-bot-copy branch April 13, 2022 05:05
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 30, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.0](v2.8.0...v3.0.0) (2022-06-29)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#272)

### Features

* Deprecate format specific `row_count` field in Read API ([#249](#249)) ([fb8acf1](fb8acf1))


### Bug Fixes

* fixes for dynamic routing and streaming descriptors ([#274](#274)) ([4271ea0](4271ea0))
* Modify client lib retry policy for CreateWriteStream with longer backoff, more error code and longer overall time ([#279](#279)) ([849cc23](849cc23))


### Build System

* update library to use Node 12 ([#272](#272)) ([5e774e6](5e774e6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.0](googleapis/nodejs-bigquery-storage@v2.8.0...v3.0.0) (2022-06-29)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#272)

### Features

* Deprecate format specific `row_count` field in Read API ([#249](googleapis/nodejs-bigquery-storage#249)) ([fb8acf1](googleapis/nodejs-bigquery-storage@fb8acf1))


### Bug Fixes

* fixes for dynamic routing and streaming descriptors ([#274](googleapis/nodejs-bigquery-storage#274)) ([4271ea0](googleapis/nodejs-bigquery-storage@4271ea0))
* Modify client lib retry policy for CreateWriteStream with longer backoff, more error code and longer overall time ([#279](googleapis/nodejs-bigquery-storage#279)) ([849cc23](googleapis/nodejs-bigquery-storage@849cc23))


### Build System

* update library to use Node 12 ([#272](googleapis/nodejs-bigquery-storage#272)) ([5e774e6](googleapis/nodejs-bigquery-storage@5e774e6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. owl-bot-copy owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants