Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: migrate to node 14 #354

Merged
merged 6 commits into from
Aug 1, 2023
Merged

chore!: migrate to node 14 #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d23c2c3
chore!: migrate to node 14
alvarowolfx Jul 31, 2023
fe50463
chore: update samples to node 14
alvarowolfx Jul 31, 2023
5f15659
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 31, 2023
777c156
fix: revert owlbot lint
alvarowolfx Aug 1, 2023
bec5bdc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 1, 2023
6db9ddd
fix: revert owlbot lint
alvarowolfx Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (12)
- test (14)
- test (16)
- test (18)
- cla/google
- windows
- OwlBot Post Processor
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16, 18]
node: [14, 16, 18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
24 changes: 0 additions & 24 deletions .kokoro/continuous/node12/common.cfg
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node12/lint.cfg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/samples-test.cfg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/system-test.cfg
View file
Open in desktop

This file was deleted.

Empty file removed .kokoro/continuous/node12/test.cfg
View file
Open in desktop
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node12/common.cfg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/samples-test.cfg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/system-test.cfg
View file
Open in desktop

This file was deleted.

Empty file removed .kokoro/presubmit/node12/test.cfg
View file
Open in desktop
Empty file.
11 changes: 6 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,28 +27,29 @@
"precompile": "gts clean"
},
"dependencies": {
"google-gax": "^3.5.2"
"google-gax": "^4.0.3"
},
"devDependencies": {
"@types/mocha": "^9.0.0",
"@types/node": "^18.0.0",
"@types/sinon": "^10.0.0",
"c8": "^8.0.0",
"gts": "^3.1.0",
"gapic-tools": "^0.1.8",
"gts": "^5.0.0",
"jsdoc": "^4.0.0",
"jsdoc-fresh": "^2.0.0",
"jsdoc-region-tag": "^2.0.0",
"linkinator": "^4.0.0",
"linkinator": "^5.0.0",
"mocha": "^9.2.2",
"null-loader": "^4.0.0",
"pack-n-play": "^1.0.0-2",
"sinon": "^15.0.0",
"ts-loader": "^9.0.0",
"typescript": "^4.8.3",
"typescript": "^5.1.6",
"webpack": "^5.0.0",
"webpack-cli": "^5.0.0"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
}
}
8 changes: 4 additions & 4 deletions samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "Apache-2.0",
"author": "Google LLC",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"files": [
"*.js"
Expand All @@ -13,11 +13,11 @@
"test": "c8 mocha --timeout 600000 test/*.js"
},
"dependencies": {
"@google-cloud/bigquery": "^6.2.0",
"@google-cloud/bigquery": "^7.0.0",
"@google-cloud/bigquery-storage": "^3.4.0",
"avsc": "^5.4.18",
"google-gax": "^3.5.2",
"protobufjs": "^7.2.2",
"google-gax": "^4.0.3",
"protobufjs": "^7.2.4",
"snappy": "^7.0.0"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions src/v1/big_query_read_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ export class BigQueryReadClient {
| protos.google.cloud.bigquery.storage.v1.ICreateReadSessionRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
createReadSession(
Expand Down Expand Up @@ -469,7 +469,7 @@ export class BigQueryReadClient {
| protos.google.cloud.bigquery.storage.v1.ICreateReadSessionRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -536,7 +536,7 @@ export class BigQueryReadClient {
| protos.google.cloud.bigquery.storage.v1.ISplitReadStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
splitReadStream(
Expand Down Expand Up @@ -585,7 +585,7 @@ export class BigQueryReadClient {
| protos.google.cloud.bigquery.storage.v1.ISplitReadStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down
20 changes: 10 additions & 10 deletions src/v1/big_query_write_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.ICreateWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
createWriteStream(
Expand Down Expand Up @@ -443,7 +443,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.ICreateWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -495,7 +495,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IGetWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
getWriteStream(
Expand Down Expand Up @@ -544,7 +544,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IGetWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -594,7 +594,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IFinalizeWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
finalizeWriteStream(
Expand Down Expand Up @@ -643,7 +643,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IFinalizeWriteStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -699,7 +699,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IBatchCommitWriteStreamsRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
batchCommitWriteStreams(
Expand Down Expand Up @@ -748,7 +748,7 @@ export class BigQueryWriteClient {
| protos.google.cloud.bigquery.storage.v1.IBatchCommitWriteStreamsRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -807,7 +807,7 @@ export class BigQueryWriteClient {
[
protos.google.cloud.bigquery.storage.v1.IFlushRowsResponse,
protos.google.cloud.bigquery.storage.v1.IFlushRowsRequest | undefined,
{} | undefined
{} | undefined,
]
>;
flushRows(
Expand Down Expand Up @@ -853,7 +853,7 @@ export class BigQueryWriteClient {
[
protos.google.cloud.bigquery.storage.v1.IFlushRowsResponse,
protos.google.cloud.bigquery.storage.v1.IFlushRowsRequest | undefined,
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down
16 changes: 8 additions & 8 deletions src/v1beta1/big_query_storage_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.ICreateReadSessionRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
createReadSession(
Expand Down Expand Up @@ -463,7 +463,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.ICreateReadSessionRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -519,7 +519,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.IBatchCreateReadSessionStreamsRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
batchCreateReadSessionStreams(
Expand Down Expand Up @@ -568,7 +568,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.IBatchCreateReadSessionStreamsRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -633,7 +633,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.IFinalizeStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
finalizeStream(
Expand Down Expand Up @@ -682,7 +682,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.IFinalizeStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -750,7 +750,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.ISplitReadStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
>;
splitReadStream(
Expand Down Expand Up @@ -799,7 +799,7 @@ export class BigQueryStorageClient {
| protos.google.cloud.bigquery.storage.v1beta1.ISplitReadStreamRequest
| undefined
),
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down