fix: handle null query parameter value (#920)

* fix: update to handle null query param * refactor * update * update null check * removes _isCustomType stub from null parameter values test
googleapis · Jun 6, 2021 · 3bf900a · 3bf900a
1 parent b703db8
commit 3bf900a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/bigquery.ts b/src/bigquery.ts
@@ -1113,7 +1113,10 @@ export class BigQuery extends common.Service {
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private static _getValue(value: any, type: ValueType): any {
-    if (value.type!) type = value;
+    if (value === null) {
+      return null;
+    }
+    if (value.type) type = value;
     return BigQuery._isCustomType(type) ? value.value : value;
   }
 

diff --git a/test/bigquery.ts b/test/bigquery.ts
@@ -1470,6 +1470,13 @@ describe('BigQuery', () => {
           geography.value
         );
       });
+
+      it('should handle null values', () => {
+        const value = null;
+        const type = 'TYPE';
+
+        assert.strictEqual(BigQuery._getValue(value, type), value);
+      });
     });
 
     describe('_isCustomType', () => {