Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer usage of projectId from the Dataset #1326

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

alvarowolfx
Copy link
Contributor

Make the internal projectId attribute on the Dataset class required and use it instead of the one set on the Client. This way all Datasets by default uses the Client projectId, but it can be override manually by the user if needed (which was enabled on PR #1230). This fixes some issues with users wanting to make operations on different projects with the same client.

Fixes #1133 #1265 🦕

@alvarowolfx alvarowolfx requested review from a team as code owners January 19, 2024 18:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jan 19, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API methods use overall connection project instead of object's project
2 participants