Use async/await in samples #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
|
FWIW the GCF samples include both 6 and 8 (where applicable).
Do we have any relevant data here? (Ping us internally if it's non-public.)
…On Sun, Sep 16, 2018, 6:43 PM Justin Beckwith ***@***.***> wrote:
Mostly doing this to start a conversation :) What do y'all think of using
async/await in our samples? I figure, we tell people to start with the
latest LTS version of nodejs, which is 8 at this stage 🤷♂️ Node.js 6 is
6 months from death, so I don't feel too bad doing this just in the samples.
Thoughts?
@googleapis/node-team <https://github.com/orgs/googleapis/teams/node-team>
@fhinkel <https://github.com/fhinkel> @ace-n <https://github.com/ace-n>
------------------------------
You can view, comment on, or merge this pull request online at:
#193
Commit Summary
- Use async/await in samples
File Changes
- *M* samples/datasets.js
<https://github.com/googleapis/nodejs-bigquery/pull/193/files#diff-0>
(52)
- *M* samples/queries.js
<https://github.com/googleapis/nodejs-bigquery/pull/193/files#diff-1>
(96)
- *M* samples/quickstart.js
<https://github.com/googleapis/nodejs-bigquery/pull/193/files#diff-2>
(19)
- *M* samples/tables.js
<https://github.com/googleapis/nodejs-bigquery/pull/193/files#diff-3>
(211)
Patch Links:
- https://github.com/googleapis/nodejs-bigquery/pull/193.patch
- https://github.com/googleapis/nodejs-bigquery/pull/193.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACM8xQwz3gkHBiMuk62MBGzGH011bAZoks5ubv40gaJpZM4WrJ9y>
.
|
|
At this point it makes sense for the samples to assume async/await support. Node 6 will be EOL in April. It is declining in usage (see https://nodejs.org/metrics) and already Node 8 seems be getting 3x the downloads as Node 6. |
|
Yeah, I think we can start with |
|
@fhinkel what are your thoughts on the way I eliminated the error handling? We used to console.log the errors, now I am just letting the async method throw. Is this the pattern we want to roll with for our samples? |
|
Looks good. You'd still see the error message in the stack trace, right? Maybe add one example that uses the |
|
So anyone willing to approve it then? 🤣 |
tswast
approved these changes
Sep 20, 2018
|
🤷♂️ I'll take it |
ofrobots
reviewed
Sep 21, 2018
| .catch(err => { | ||
| console.error('ERROR:', err); | ||
| }); | ||
| const [rows] = await bigquery.query(options); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly doing this to start a conversation :) What do y'all think of using async/await in our samples? I figure, we tell people to start with the latest LTS version of nodejs, which is 8 at this stage 🤷♂️ Node.js 6 is 6 months from death, so I don't feel too bad doing this just in the samples.
Thoughts?
@googleapis/node-team @fhinkel @ace-n