Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throw errors for missing resource ids #342

Merged
merged 4 commits into from
Feb 5, 2019
Merged

feat: throw errors for missing resource ids #342

merged 4 commits into from
Feb 5, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Feb 1, 2019 •
edited
Loading

Fixes #325

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
@callmehiphop callmehiphop requested review from stephenplusplus and a team February 1, 2019 22:56
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2019
@JustinBeckwith JustinBeckwith merged commit a1c9e3d into googleapis:master Feb 5, 2019
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callmehiphop @JustinBeckwith @googlebot @kokoro-team