Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): link to upstream limit docs #376

Merged
merged 2 commits into from
Mar 11, 2019
Merged

docs(table): link to upstream limit docs #376

merged 2 commits into from
Mar 11, 2019

Conversation

callmehiphop
Copy link
Contributor

Fixes #347

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2019
@callmehiphop callmehiphop added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 11, 2019
@callmehiphop
Copy link
Contributor Author

Let's hold off on merging for a minute, I couldn't replicate #375 locally, so I'm going to try and do it here.

@callmehiphop callmehiphop removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70cb9f...d817cf2. Read the comment docs.

@callmehiphop callmehiphop merged commit 4fe36f7 into googleapis:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants