Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): adds queryParamsNamed and queryParamsPositional #381

Merged
merged 5 commits into from
Mar 15, 2019
Merged

docs(samples): adds queryParamsNamed and queryParamsPositional #381

merged 5 commits into from
Mar 15, 2019

Conversation

steffnay
Copy link
Contributor

Fixes 380

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are a lot of comments here - but it's not your fault at all. Running repo-tools blasts away a lot of things that shouldn't be changed, so you have to kinda be careful about what gets committed. Apologies!

.eslintignore Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.jsdoc.js Outdated Show resolved Hide resolved
.nycrc Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
samples/README.md Show resolved Hide resolved
samples/system-test/.eslintrc.yml Outdated Show resolved Hide resolved
system-test/.eslintrc.yml Outdated Show resolved Hide resolved
@steffnay steffnay requested a review from JustinBeckwith March 15, 2019 17:37
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8caa112...f9ec888. Read the comment docs.

@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2019
@jkwlui
Copy link
Member

jkwlui commented Mar 15, 2019

@JustinBeckwith please force merge this. It has 2 links that links to code in samples/ which doesn't exist yet unless merged to master:

[404] https://github.com/googleapis/nodejs-bigquery/blob/master/samples/queryParamsNamed.js
[404] https://github.com/googleapis/nodejs-bigquery/blob/master/samples/queryParamsPositional.js

@JustinBeckwith JustinBeckwith merged commit 2383b70 into googleapis:master Mar 15, 2019
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants