-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): adds queryParamsNamed and queryParamsPositional #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are a lot of comments here - but it's not your fault at all. Running repo-tools
blasts away a lot of things that shouldn't be changed, so you have to kinda be careful about what gets committed. Apologies!
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1 Continue to review full report at Codecov.
|
@JustinBeckwith please force merge this. It has 2 links that links to code in samples/ which doesn't exist yet unless merged to [404] https://github.com/googleapis/nodejs-bigquery/blob/master/samples/queryParamsNamed.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes 380