Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(samples): split query and table samples into separate files #384

Merged
merged 10 commits into from
Mar 15, 2019
Merged

refactor(samples): split query and table samples into separate files #384

merged 10 commits into from
Mar 15, 2019

Conversation

steffnay
Copy link
Contributor

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2019
@steffnay steffnay requested a review from jkwlui March 15, 2019 18:48
jkwlui
jkwlui suggested changes Mar 15, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2383b70...be802d2. Read the comment docs.

@steffnay steffnay requested a review from jkwlui March 15, 2019 19:53
JustinBeckwith
JustinBeckwith approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please delete samples/default.profraw? Other than that, LGTM

@steffnay steffnay requested a review from JustinBeckwith March 15, 2019 21:45
@JustinBeckwith JustinBeckwith merged commit 8fcd1c9 into googleapis:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffnay @JustinBeckwith @jkwlui @googlebot