Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): duplicate readme sample names #512

Merged

Conversation

laljikanjareeya
Copy link
Contributor

Fixes #505

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           5        5           
  Lines         698      698           
  Branches      192      192           
=======================================
  Hits          694      694           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e502df2...8223616. Read the comment docs.

@bcoe bcoe requested review from jkwlui and AVaksman July 31, 2019 18:07
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laljikanjareeya this table actually get auto generated from meta information in the samples/ folder, if you update the title: stanza in the corresponding sample files, the nightly synthtool job should fix up the table for you, see:

// title: BigQuery Update Model

@AVaksman
Copy link
Contributor

Seems need to change title from "BigQuery Update Model" to an appropriate one in
Delete Label Dataset
Get Dataset Labels
BigQuery Get Table
Get Table Labels
BigQuery Label Dataset

@JustinBeckwith JustinBeckwith merged commit 56040f5 into googleapis:master Aug 1, 2019
@laljikanjareeya laljikanjareeya deleted the readme-sample-names-505 branch August 1, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many duplicated sample names in README
5 participants