Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): allow opting out of default insert id #582

Merged
merged 4 commits into from
Dec 5, 2019
Merged

feat(table): allow opting out of default insert id #582

merged 4 commits into from
Dec 5, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Nov 21, 2019 •
edited
Loading

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #581 🦕

@callmehiphop callmehiphop requested review from tswast and a team November 21, 2019 21:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2019
@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #582 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   99.43%   99.43%   +<.01%     
==========================================
  Files           6        6              
  Lines         707      711       +4     
  Branches      192      193       +1     
==========================================
+ Hits          703      707       +4     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/table.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99aad91...4c41882. Read the comment docs.

@callmehiphop callmehiphop marked this pull request as ready for review November 21, 2019 22:17
@callmehiphop
Copy link
Contributor Author

@tswast hopefully I understood the request!

tswast
tswast approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

@callmehiphop callmehiphop merged commit 6bf2dbd into googleapis:master Dec 5, 2019
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: provide a way to opt-out of sending row IDs when streaming rows to a BigQuery table
4 participants
@callmehiphop @tswast @stephenplusplus @googlebot