Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle null query parameter value #920

Merged
merged 9 commits into from
Jun 6, 2021
Merged

fix: handle null query parameter value #920

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
18dc084
fix: update to handle null query param
steffnay Jan 31, 2021
bbcad17
refactor
steffnay Jan 31, 2021
d45b876
update
steffnay Jan 31, 2021
f19fb94
update null check
steffnay Feb 2, 2021
fdb0a4b
Merge branch 'master' into null-param
steffnay Feb 4, 2021
ef22829
removes _isCustomType stub from null parameter values test
steffnay Feb 4, 2021
4102305
Merge branch 'null-param' of github.com:steffnay/nodejs-bigquery into…
steffnay Feb 4, 2021
81f7d52
Merge branch 'master' into null-param
steffnay May 31, 2021
fa57ad3
Merge branch 'master' into null-param
steffnay Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/bigquery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,10 @@ export class BigQuery extends common.Service {

// eslint-disable-next-line @typescript-eslint/no-explicit-any
private static _getValue(value: any, type: ValueType): any {
if (value.type!) type = value;
if (value === null) {
return null;
}
if (value.type) type = value;
return BigQuery._isCustomType(type) ? value.value : value;
}

Expand Down
7 changes: 7 additions & 0 deletions test/bigquery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,6 +1470,13 @@ describe('BigQuery', () => {
geography.value
);
});

it('should handle null values', () => {
const value = null;
const type = 'TYPE';

assert.strictEqual(BigQuery._getValue(value, type), value);
});
});

describe('_isCustomType', () => {
Expand Down