chore!: drop support for node.js 8 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 99.79% 99.59% -0.21%
==========================================
Files 5 5
Lines 1955 1953 -2
Branches 172 171 -1
==========================================
- Hits 1951 1945 -6
- Misses 4 7 +3
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
The Windows CI/CD issue is most likely due to linting being run as a post test step. We might want to dig into why linting has issues on Windows ... but for now, it might be okay to just drop that post test check. |
alexander-fenster
approved these changes
Mar 26, 2020
bcoe
approved these changes
Mar 26, 2020
Merged
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
alexander-fenster
pushed a commit
that referenced
this pull request
Apr 1, 2020
* Change triggered by none of the following: This git repo (https://github.com/googleapis/nodejs-common.git) Git repo https://github.com/googleapis/synthtool.git * fix(deps): update dependency @google-cloud/projectify to v2 (#553) 23030a2 commit 23030a2 Author: WhiteSource Renovate <bot@renovateapp.com> Date: Wed Mar 25 22:16:03 2020 +0100 fix(deps): update dependency @google-cloud/projectify to v2 (#553) * fix(deps): update dependency @google-cloud/promisify to v2 (#552) 63175e0 commit 63175e0 Author: WhiteSource Renovate <bot@renovateapp.com> Date: Wed Mar 25 22:35:58 2020 +0100 fix(deps): update dependency @google-cloud/promisify to v2 (#552) * chore!: drop support for node.js 8 (#554) 9f41047 commit 9f41047 Author: Justin Beckwith <justin.beckwith@gmail.com> Date: Thu Mar 26 12:11:44 2020 -0700 chore!: drop support for node.js 8 (#554) * chore: release 3.0.0 (#542) 13ae85c commit 13ae85c Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Fri Mar 27 12:51:09 2020 -0700 chore: release 3.0.0 (#542) * fix(deps): update dependency google-auth-library to v6 (#556) 03a8a54 commit 03a8a54 Author: WhiteSource Renovate <bot@renovateapp.com> Date: Fri Mar 27 21:12:35 2020 +0100 fix(deps): update dependency google-auth-library to v6 (#556) * build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#559) 575353f commit 575353f Author: Benjamin E. Coe <bencoe@google.com> Date: Tue Mar 31 18:35:28 2020 -0700 build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#559) * docs: document the release schedule we follow (#454) googleapis/synthtool@6a17abc commit 6a17abc7652e2fe563e1288c6e8c23fc260dda97 Author: Benjamin E. Coe <bencoe@google.com> Date: Mon Mar 23 19:22:34 2020 -0700 docs: document the release schedule we follow (#454) * fix: do not run node 8 CI (#456) googleapis/synthtool@1b4cc80 commit 1b4cc80a7aaf164f6241937dd87f3bd1f4149e0c Author: Alexander Fenster <fenster@google.com> Date: Wed Mar 25 08:01:31 2020 -0700 fix: do not run node 8 CI (#456) * fix: update template files for Node.js libraries (#463) googleapis/synthtool@9982024 commit 99820243d348191bc9c634f2b48ddf65096285ed Author: Alexander Fenster <fenster@google.com> Date: Tue Mar 31 11:56:27 2020 -0700 fix: update template files for Node.js libraries (#463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.