Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

docs: fixes small typo #553

Merged
merged 4 commits into from
May 19, 2021
Merged

docs: fixes small typo #553

merged 4 commits into from
May 19, 2021

Conversation

haraldreingruber
Copy link
Contributor

It's just a small typo fix. Maybe this is helpful.

@haraldreingruber haraldreingruber requested a review from a team as a code owner May 8, 2021 10:35
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/nodejs-compute API. label May 8, 2021
@google-cla
Copy link

google-cla bot commented May 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label May 8, 2021
@haraldreingruber
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 8, 2021
@JustinBeckwith JustinBeckwith changed the title Fixes small typo docs: fixes small typo May 8, 2021
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2021
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #553 (ce8ccbc) into master (75c446a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files          22       22              
  Lines       11952    11948       -4     
==========================================
- Hits        11906    11902       -4     
  Misses         46       46              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/zone.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c446a...ce8ccbc. Read the comment docs.

@tmatsuo
Copy link
Contributor

tmatsuo commented May 17, 2021

@haraldreingruber

It's not your fault, but this file has [START gce_startup_script], but doesn't have matching [END gce_startup_script].
I think you can add [END gce_startup_script] at the end of the function.
Can you add it?

Also, the conventional commit looks at the commit message of the first commit, not the title of the PR, so you may need to change the commit message. You can easily change the commit message with git commit --amend command.

@haraldreingruber
Copy link
Contributor Author

@tmatsuo sure, no problem.
Let me know if that works for you?

@tmatsuo
Copy link
Contributor

tmatsuo commented May 18, 2021

@haraldreingruber
Perfect! Thank you for the fix!

@tmatsuo
Copy link
Contributor

tmatsuo commented May 18, 2021

The lint seems failing. Maybe I can push the change.

@tmatsuo tmatsuo added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 18, 2021
@tmatsuo tmatsuo merged commit 7119ace into googleapis:master May 19, 2021
alexander-fenster pushed a commit that referenced this pull request Jun 16, 2021
* docs: fixes small typo (#553)

* docs: Fixes small typo

* docs: Add missing gce_startup_script end comment

* lint fix

* copyright fix

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>

* [CHANGE ME] Re-generated to pick up changes from synthtool. (#555)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a89e0ec2-51a7-4b0c-8b07-d5c6dd31a58b/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@b891fb4

* feat: add `gcf-owl-bot[bot]` to `ignoreAuthors` (#557)

* feat: add `gcf-owl-bot[bot]` to `ignoreAuthors`

Related: googleapis/repo-automation-bots#1751

* feat: add `yoshi-automation` to `ignoreAuthors`

Source-Author: Daniel Bankhead <danielbankhead@google.com>
Source-Date: Tue May 18 15:08:47 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 7332178a11ddddc91188dc0f25bca1ccadcaa6c6
Source-Link: googleapis/synthtool@7332178

* chore: linting updates (#554)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/0ed6cac5-746d-445c-844b-b4b85a0aa18a/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

* chore: migrate to owl bot (#562)

* chore: migrate to owl bot

* chore: copy files from googleapis-gen efb563da184f479fabf98da24f969494944d059b

* chore: run the post processor

* chore: release 2.5.0 (#561)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: flaky test (#563)

* fix: flaky test

* fix: flaky test

* fix: compute test

* fix: run npm lint

* remove node-fetch

* fix: make test conditional

* chore: Report warning on `.github/workflows/ci.yaml` (#565)

* fix: Report warning on `.github/workflows/ci.yaml`

Not all files in `.github/workflows` are managed, only `ci.yaml`.

Related false-positive: googleapis/repo-automation-bots#1952 (comment)

* fix: Report warning on `.github/workflows/ci.yaml`

Not all files in `.github/workflows` are managed, only `ci.yaml`.
Source-Link: googleapis/synthtool@2430f8d
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:14aaee566d6fc07716bb92da416195156e47a4777e7d1cd2bb3e28c46fe30fe2

* chore(nodejs): use cloud-rad publication process (#1112) (#570)

VERSION is used in @google-cloud/cloud-rad to publish ref docs for
a particular version. Pass VERSION in via Stubby or Fusion.
Source-Link: googleapis/synthtool@740366b
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:bbdd52de226c00df3356cdf25460397b429ab49552becca645adbc412f6a4ed5

* build: add auto-approve to Node libraries (#1100) (#572)

* build: add auto-approve to Node libraries

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Link: googleapis/synthtool@5cae043
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:65aa68f2242c172345d7c1e780bced839bfdc344955d6aa460aa63b4481d93e5

* chore: release 2.5.1 (#571)

:robot: I have created a release \*beep\* \*boop\*
---
### [2.5.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.5.0...v2.5.1) (2021-06-10)


### Bug Fixes

* flaky test ([#563](https://www.github.com/googleapis/nodejs-compute/issues/563)) ([827a333](https://www.github.com/googleapis/nodejs-compute/commit/827a333443d6716b232fd21e00cc61a4df16aff0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore(nodejs): remove api-extractor dependencies (#574)

* build: remove errant comma (#1113) (#576)

Source-Link: googleapis/synthtool@41ccd8c
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:c9c7828c165b1985579098978877935ee52dda2b1b538087514fd24fa2443e7a

* merge package with master

* remove the unintentional deleted files

Co-authored-by: Harald Reingruber <haraldreingruber@users.noreply.github.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Co-authored-by: Yoshi Automation Bot <yoshi-automation@google.com>
Co-authored-by: Jeffrey Rennie <rennie@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/nodejs-compute API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants