This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
docs(readme): diregapic release #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: compute
|
Hi @FrodoTheTrue, these files are autogenerated. In order to make changes, I think you'd want to make changes to the partials file, like so. But the Would you mind providing some more context on why you're making this PR? Thanks in advance. |
JustinBeckwith
approved these changes
Jun 8, 2021
| return new Promise(resolve => { | ||
| setTimeout(resolve, timeoutMs); | ||
| async function listInstances() { | ||
| const client = new compute.InstancesClient({fallback: 'rest'}); |
There was a problem hiding this comment.
What happens if the customer doesn't set fallback: 'rest'? Or is that going to be required for every instance instantiation?
There was a problem hiding this comment.
In this case user will use grpc transport. GAPIC team will fix it (rest will be by default)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕