Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

tests: add pagination tests #595

Merged
merged 2 commits into from
Aug 11, 2021
Merged

tests: add pagination tests #595

merged 2 commits into from
Aug 11, 2021

Conversation

georgiyekkert
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@georgiyekkert georgiyekkert requested a review from a team as a code owner August 6, 2021 20:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/nodejs-compute API. label Aug 6, 2021
@georgiyekkert
Copy link
Contributor Author

@alexander-fenster please take a look

summer-ji-eng
summer-ji-eng approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@summer-ji-eng summer-ji-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@summer-ji-eng summer-ji-eng merged commit 28a3b20 into googleapis:diregapic Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@summer-ji-eng summer-ji-eng summer-ji-eng approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/nodejs-compute API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgiyekkert @summer-ji-eng