feat: add order field to TagField and TagTemplateField #157
Conversation
googlebot
added
the
cla: yes
xiaozhenliu-gg5
added
the
do not merge
|
This is waiting for proto change (fixing broken links & proto updates) |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 8 8
Lines 11507 11511 +4
Branches 423 423
=======================================
+ Hits 11304 11308 +4
Misses 199 199
Partials 4 4
Continue to review full report at Codecov.
|
xiaozhenliu-gg5
requested review from
alexander-fenster,
bcoe and
JustinBeckwith
There was a problem hiding this comment.
This is not a chore:, since the proto changes contain a new feature (int32 order = 7 [(google.api.field_behavior) = OUTPUT_ONLY]; added in some response messages, maybe more - I didn't check in detail). If I remember correctly this is your own description of the change :) googleapis/googleapis@b5e9b0b It should get here as well, since it's a new feature for the library users.
xiaozhenliu-gg5
changed the title
|
Sure, modified the title and description details, this would be a new feature for users, but not a breaking change I think. Thank you! @alexander-fenster |
bcoe
changed the title
|
@xiaozhenliu-gg5 I would probably merge this calling out the most significant feature being added, which I think would be: |
|
Thank you @bcoe ! |
xiaozhenliu-gg5
removed
the
do not merge
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.0.0...v2.1.0) (2020-06-16) ### Features * add order field to TagField and TagTemplateField ([#157](https://www.github.com/googleapis/nodejs-datacatalog/issues/157)) ([70c23c2](https://www.github.com/googleapis/nodejs-datacatalog/commit/70c23c2b609bd24901dc902090e23fbf92b55895)) * move ts target to es2018 from es2016 ([#172](https://www.github.com/googleapis/nodejs-datacatalog/issues/172)) ([e354dde](https://www.github.com/googleapis/nodejs-datacatalog/commit/e354ddeeeedd3e106c50ed579075f23c9d9c5bb5)) * promote library to GA ([#177](https://www.github.com/googleapis/nodejs-datacatalog/issues/177)) ([ac11090](https://www.github.com/googleapis/nodejs-datacatalog/commit/ac110906b723f362024318295e3de6743c905b7e)) ### Bug Fixes * proper fallback option handling ([51df672](https://www.github.com/googleapis/nodejs-datacatalog/commit/51df6721306ab6d2d9bf6919b0f3f432ca85b4ab)) * regenerate unit tests ([#163](https://www.github.com/googleapis/nodejs-datacatalog/issues/163)) ([4593117](https://www.github.com/googleapis/nodejs-datacatalog/commit/45931176d266d364e0508039cf6a4e284ad2923d)) * synth.py clean up for multiple version ([#167](https://www.github.com/googleapis/nodejs-datacatalog/issues/167)) ([c799604](https://www.github.com/googleapis/nodejs-datacatalog/commit/c799604b2d29269006ff39748afb78302ce46ca2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
orderfield toTagFieldandTagTemplateFieldmessage in tags.proto