Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change tests to use new filter and use gax warn for warning just once #1185

Merged
merged 11 commits into from
Oct 23, 2023
Merged

fix: Change tests to use new filter and use gax warn for warning just once #1185

merged 11 commits into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. trim operator 

    In the legacy version of filter we trim the operator. We should do this here too.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    37a0a28 View commit details
    Browse the repository at this point in the history

  2. In test cases, replace various filter calls 

    Always pass entity filters into the filter function in tests to reflect new behavior.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    583301d View commit details
    Browse the repository at this point in the history

  3. accept string too 

    A string is needed as an input parameter because we might trim it to get an operator.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c6f0f4e View commit details
    Browse the repository at this point in the history

  4. Use .filter the old way 

    Revert changes on the .filter method
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    483a71d View commit details
    Browse the repository at this point in the history

  5. Change docs to use new filter 

    The new property filter should be used and this should be reflected in the doc comments.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c290481 View commit details
    Browse the repository at this point in the history

  6. Use new Property filter 

    In entity.ts, use the new property filter constructor.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    868d85a View commit details
    Browse the repository at this point in the history

  7. Revert changes to operator 

    The changes cause compiler errors. Do not trim the operator for now.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    79ec7a3 View commit details
    Browse the repository at this point in the history

  8. Move test up and add change 

    Add change to issue warning just once. Use google-gax so that the warning is issued just once.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d6b0207 View commit details
    Browse the repository at this point in the history

  9. Revert "Change docs to use new filter" 

    This reverts commit c290481.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    6409509 View commit details
    Browse the repository at this point in the history

  10. run linter

    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    997a7f6 View commit details
    Browse the repository at this point in the history

  11. Add a test to ensure just one warning 

    A test to make sure the warning is emitted just once might provide proper coverage.
    @danieljbruce
    danieljbruce committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a193f29 View commit details
    Browse the repository at this point in the history