Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support excludeFromIndexes for primitives in arrays. #18

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

beaulac
Copy link
Contributor

@beaulac beaulac commented Dec 18, 2017

Fixes #13. PR ported from this one. In addition, adds an example to the documentation.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@stephenplusplus
Copy link
Contributor

Thank you 🙏 Would you mind also copying over the change to the system-test file? https://github.com/GoogleCloudPlatform/google-cloud-node/pull/2773/files#diff-def9264f47890d5d0e327fb24796179b

@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         639    643    +4     
=====================================
+ Hits          639    643    +4
Impacted Files Coverage Δ
src/request.js 100% <ø> (ø) ⬆️
src/entity.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f0244...834f1b7. Read the comment docs.

@beaulac
Copy link
Contributor Author

beaulac commented Dec 18, 2017

Just did it; had forgotten about that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants