Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prefer-const in the eslint config #197

Merged
merged 2 commits into from
Sep 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ rules:
eqeqeq: error
no-warning-comments: warn
no-var: error
prefer-const: error
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
"test-no-cover": "mocha test/*.js",
"test": "npm run cover",
"system-test": "mocha system-test/*.js --timeout 600000"
"system-test": "mocha system-test/*.js --timeout 600000",
"fix": "eslint '**/*.js' --fix && npm run prettier"
},
"dependencies": {
"@google-cloud/projectify": "^0.3.0",
Expand Down
4 changes: 2 additions & 2 deletions samples/concepts.js
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ class Metadata extends TestHelper {
});

console.log('Properties by Kind:');
for (let key in propertiesByKind) {
for (const key in propertiesByKind) {
console.log(key, propertiesByKind[key]);
}

Expand Down Expand Up @@ -599,7 +599,7 @@ class Metadata extends TestHelper {
});

console.log('Task property representations:');
for (let key in representationsByProperty) {
for (const key in representationsByProperty) {
console.log(key, representationsByProperty[key]);
}

Expand Down
2 changes: 1 addition & 1 deletion src/v1/datastore_client.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class DatastoreClient {
'allocateIds',
'reserveIds',
];
for (let methodName of datastoreStubMethods) {
for (const methodName of datastoreStubMethods) {
this._innerApiCalls[methodName] = gax.createApiCall(
datastoreStub.then(
stub =>
Expand Down
4 changes: 1 addition & 3 deletions test/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,6 @@ describe('Transaction', function() {
});

it('should localize request function', function(done) {
let transaction;

const fakeDataset = {
request_: {
bind: function(context) {
Expand All @@ -136,7 +134,7 @@ describe('Transaction', function() {
},
};

transaction = new Transaction(fakeDataset);
const transaction = new Transaction(fakeDataset);
});

it('should localize default properties', function() {
Expand Down