Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): import from 'grpc' -> '@grpc/grpc-js' #446

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Jun 25, 2019

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
@AVaksman AVaksman marked this pull request as ready for review June 25, 2019 20:32
@AVaksman AVaksman requested a review from a team June 25, 2019 20:33
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files           5        5           
  Lines         617      617           
  Branches      145      145           
=======================================
  Hits          605      605           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b6311...4f8bbfa. Read the comment docs.

@tseaver
Copy link

tseaver commented Jun 26, 2019

@AVaksman the yoshi team is overbroad for review here: it picks up developers across all languages.

@JustinBeckwith JustinBeckwith merged commit d8a8c81 into googleapis:master Jun 26, 2019
@AVaksman
Copy link
Contributor Author

AVaksman commented Jun 27, 2019

@AVaksman the yoshi team is overbroad for review here: it picks up developers across all languages.

@tseaver understood
meant to select googleapis/yoshi-nodejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants