Skip to content

Commit

Permalink
Using Partial for QueryOptions
Browse files Browse the repository at this point in the history
  • Loading branch information
schmidt-sebastian committed Mar 14, 2019
1 parent 7d646f8 commit 32d35b5
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions dev/src/reference.ts
Original file line number Diff line number Diff line change
Expand Up @@ -907,18 +907,7 @@ export class QueryOptions {
* Returns the union of the current and the provided options.
* @private
*/
with(settings: {
parentPath?: ResourcePath;
collectionId?: string;
allDescendants?: boolean;
fieldFilters?: FieldFilter[];
fieldOrders?: FieldOrder[];
startAt?: QueryCursor;
endAt?: QueryCursor;
limit?: number;
offset?: number;
projection?: api.StructuredQuery.IProjection;
}): QueryOptions {
with(settings: Partial<QueryOptions>): QueryOptions {

This comment has been minimized.

Copy link
@mikelehen

mikelehen Mar 14, 2019

Contributor

niiiiiiice....

This comment has been minimized.

Copy link
@schmidt-sebastian

schmidt-sebastian Mar 14, 2019

Author Contributor

It's "Ohhhh.... nice" :)

This comment has been minimized.

Copy link
@mikelehen

mikelehen Mar 14, 2019

Contributor

No, no... this one was a sincere 'niiiiiiice....' 😛

return new QueryOptions(
coalesce(settings.parentPath, this.parentPath)!,
coalesce(settings.collectionId, this.collectionId)!,
Expand Down

0 comments on commit 32d35b5

Please sign in to comment.