fix: Add underscore to bundle() (#1075)

googleapis · May 13, 2020 · ec2af9f · ec2af9f
1 parent dec477d
commit ec2af9f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/dev/src/index.ts b/dev/src/index.ts
@@ -855,7 +855,7 @@ export class Firestore {
    *
    * @private
    */
-  bundle(name?: string): BundleBuilder {
+  _bundle(name?: string): BundleBuilder {
     return new BundleBuilder(name || autoId());
   }
 

diff --git a/dev/system-test/firestore.ts b/dev/system-test/firestore.ts
@@ -2402,7 +2402,7 @@ describe('Bundle building', () => {
   afterEach(() => verifyInstance(firestore));
 
   it('succeeds when there are no results', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const query = testCol.where('sort', '==', 5);
     const snap = await query.get();
 
@@ -2437,7 +2437,7 @@ describe('Bundle building', () => {
   });
 
   it('succeeds when added document does not exist', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const snap = await testCol.doc('doc5-not-exist').get();
 
     bundle.add(snap);
@@ -2463,7 +2463,7 @@ describe('Bundle building', () => {
   });
 
   it('succeeds to save limit and limitToLast queries', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const limitQuery = testCol.orderBy('sort', 'desc').limit(1);
     const limitSnap = await limitQuery.get();
     const limitToLastQuery = testCol.orderBy('sort', 'asc').limitToLast(1);

diff --git a/dev/test/bundle.ts b/dev/test/bundle.ts
@@ -49,7 +49,7 @@ describe('Bundle Buidler', () => {
   });
 
   it('succeeds with document snapshots', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const snap1 = firestore.snapshot_(
       {
         name: `${DATABASE_ROOT}/documents/collectionId/doc1`,
@@ -99,7 +99,7 @@ describe('Bundle Buidler', () => {
   });
 
   it('succeeds with query snapshots', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const snap = firestore.snapshot_(
       {
         name: `${DATABASE_ROOT}/documents/collectionId/doc1`,
@@ -162,7 +162,7 @@ describe('Bundle Buidler', () => {
   });
 
   it('succeeds with multiple calls to build()', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
     const snap1 = firestore.snapshot_(
       {
         name: `${DATABASE_ROOT}/documents/collectionId/doc1`,
@@ -229,7 +229,7 @@ describe('Bundle Buidler', () => {
   });
 
   it('succeeds when nothing is added', async () => {
-    const bundle = firestore.bundle('test-bundle');
+    const bundle = firestore._bundle('test-bundle');
 
     // `elements` is expected to be [bundleMeta].
     const elements = await bundleToElementArray(bundle.build());